Fix bug where guess and decode would panic on memory alloc #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the guess and decode fns so they set the maximum length of the input.
Why
When an input is passed that is not valid, it can cause the xdr lib to allocate more memory than can fit into system memory if a four byte block is interpreted as a length field and is set to a really large value. The xdr lib has a limiter where we can specify what the maximum length of the input xdr so that it will fail before trying to allocate more memory than there is even in the xdr lib. This changes uses that feature.
Close #5
Merging
This change is intended to merge to
mainafter #6.