services/horizon: Limit sql queries for history endpoints to retention window #5448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
urvisavla
force-pushed
the
22/history-retention-boundary
branch
4 times, most recently
from
9021556
to
f4f83e4
Compare
urvisavla
changed the title
urvisavla
force-pushed
the
22/history-retention-boundary
branch
from
7bcc96f
to
a0894f1
Compare
tamirms
reviewed
Sep 5, 2024
tamirms
reviewed
Sep 5, 2024
urvisavla
force-pushed
the
22/history-retention-boundary
branch
from
32cf2bb
to
5c8c0cc
Compare
tamirms
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Adjust the cursor for ascending queries to start at the oldest available ledger if it precedes the oldest ledger, preventing inefficient queries due to index bloat from deleted rows.
Why
https://github.com/stellar/go-internal/issues/22
Known limitations
N/A