ingest/ledgerbackend: Skip removing storage dir when Captive-Core in front of requested ledger #4605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit improves
stellarCoreRunner
code to not remove storage dir if LCL of Captive-Core is greater than or equal requestedfrom
ledger.Why
In e3d3abc we added a code that skips removing storage dir but it was not removed if and only if
from
argument matched the LCL of Stellar-Core. The problem is that in clusters with more than one ingesting instance it's possible that other ingesting node would ingest one or more ledgers while Captive-Core instance is being restarted. In such case we should not remove storage dir but just skip the ledgers we don't need.Known limitations
[TODO or N/A]