Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/ledgerbackend: Skip removing storage dir when Captive-Core in front of requested ledger #4605

Merged

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Sep 22, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit improves stellarCoreRunner code to not remove storage dir if LCL of Captive-Core is greater than or equal requested from ledger.

Why

In e3d3abc we added a code that skips removing storage dir but it was not removed if and only if from argument matched the LCL of Stellar-Core. The problem is that in clusters with more than one ingesting instance it's possible that other ingesting node would ingest one or more ledgers while Captive-Core instance is being restarted. In such case we should not remove storage dir but just skip the ledgers we don't need.

Known limitations

[TODO or N/A]

@bartekn bartekn requested a review from a team September 22, 2022 20:55
@bartekn bartekn marked this pull request as ready for review September 22, 2022 20:55
@bartekn bartekn merged commit 621d634 into stellar:master Sep 27, 2022
@bartekn bartekn deleted the core-runner-not-remove-if-skip-ledgers-possible branch September 27, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants