Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txnbuild: Use xdr.Price to represent prices in txnbuild instead of strings. #4167

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jan 7, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fixes #2514

Use xdr.Price to represent prices in txnbuild instead of strings.

Why

It is impossible to represent prices as strings without finite decimal expansion with a reasonable number of decimal places.

Known limitations

[N/A]

@tamirms tamirms force-pushed the price-type branch 3 times, most recently from 6f11203 to 629e545 Compare January 7, 2022 13:28
@tamirms tamirms marked this pull request as ready for review January 7, 2022 13:41
@tamirms tamirms requested a review from a team January 7, 2022 13:56
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 🎉

Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if we should create txnbuild.Price struct instead of using xdr.Price.

@tamirms tamirms merged commit ca65479 into stellar:master Jan 10, 2022
@tamirms tamirms deleted the price-type branch January 10, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

txnbuild: Update all operations with price fields to accept N/D representation
3 participants