Fix transaction submission when handling large transaction payloads #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
approved these changes
May 31, 2021
| @@ -19,3 +21,15 @@ func (sr submitRequest) BuildURL() (endpoint string, err error) { | |||
| endpoint = fmt.Sprintf("%s?%s", sr.endpoint, query.Encode()) | |||
| return endpoint, err | |||
| } | |||
|
|
|||
| // HTTPRequest returns the http request for submitting transactions to a running horizon instance | |||
There was a problem hiding this comment.
Can we remove BuildURL above?
| @@ -227,6 +227,7 @@ var DefaultPublicNetClient = &Client{ | |||
| // HorizonRequest contains methods implemented by request structs for horizon endpoints. | |||
| type HorizonRequest interface { | |||
| BuildURL() (string, error) | |||
There was a problem hiding this comment.
Is BuildURL needed anymore?
There was a problem hiding this comment.
BuildURL is not needed anymore but I wanted to avoid a major version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close #3621
The payload for the submit transaction endpoint is included as a query parameter in the horizon client. When a transaction has a lengthy XDR encoding, the request url can be too long which will cause the request to fail with a "HTTP 414 URI Too Long" error. To fix this issue I have moved the transaction payload into the POST body.