txnbuild: add AddSignatureDecorated #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
May 27, 2021
txnbuild/transaction_test.go
Outdated
| xdr.DecoratedSignature{ | ||
| Hint: kp1.Hint(), | ||
| Signature: func() xdr.Signature { | ||
| sigBytes, err := base64.StdEncoding.DecodeString("Iy77JteoW/FbeiuViZpgTyvrHP4BnBOeyVOjrdb5O/MpEMwcSlYXAkCBqPt4tBDil4jIcDDLhm7TsN6aUBkIBg==") |
There was a problem hiding this comment.
This test is based on the AddSignatureBase64 test and uses the same expected inputs and outputs.
Co-authored-by: Eric Saunders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add
AddSignatureDecoratedfunction toTransaction.Why
The
Transactiontype has aAddSignatureBase64which is helpful when working with some SEPs where signatures and full signers are passed around, but sometimes people are exchanging the briefer decorated signatures. In that case there is no convenient way to attach the decorated signature to an existing transaction. The only methods available is to convert theTransactionto axdr.TransactionEnvelope. But in that case there is no way to go back to aTransactionwithout round-tripping through Base64.Known limitations
N/A