txnbuild: add SequenceNumber func to Transaction #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What Add `SequenceNumber` function to `Transaction`. ### Why Stellar transactions have a sequence number. If a transaction is valid and it is accepted into a ledger the source account of the transaction is updated such that its sequence number becomes the sequence number of the transaction. In the Go SDK a parsed transaction has no sequence number field or function directly on it. For a developer to get the sequence number they must look at the source account object. This is not intuitive and not consistent conceptually because a transaction has a sequence number and it should be a first class attribute of the transaction. In my own development using the Go SDK I spent time trying to figure out where the sequence was stored and how to get at it. I work on Stellar everyday, so if this is not intuitive to me, I suspect it isn't intuitive to others. This is likely to become even less intuitive as we plan to change the sequence number rules where the sequence number on an account does not need to be sequential. Regardless of this, it isn't intuitive today.
ire-and-curses
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add
SequenceNumberfunction toTransaction.Why
Stellar transactions have a sequence number. If a transaction is valid and it is
accepted into a ledger the source account of the transaction is updated such
that its sequence number becomes the sequence number of the transaction.
In the Go SDK a parsed transaction has no sequence number field or function
directly on it. For a developer to get the sequence number they must look at the
source account object. This is not intuitive and not consistent conceptually
because a transaction has a sequence number and it should be a first class
attribute of the transaction.
In my own development using the Go SDK I spent time trying to figure out where
the sequence was stored and how to get at it. I work on Stellar everyday, so if
this is not intuitive to me, I suspect it isn't intuitive to others.
Other Stellar SDKs, such as the JS SDK, expose it as an attribute on a
Transaction.
This is likely to become even less intuitive as we plan to change the sequence
number rules where the sequence number on an account does not need to be
sequential. Regardless of this, it isn't intuitive today.
Known limitations
N/A