txnbuild: Use correct account in ClaimableBalanceID() #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
approved these changes
Feb 12, 2021
|
|
||
| balanceId, err := tx.ClaimableBalanceID(0) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, "0000000095001252ab3b4d16adbfa5364ce526dfcda03cb2258b827edbb2e0450087be51", balanceId) |
There was a problem hiding this comment.
How did you determine this ID to compare against?
This depends on your answer to the above, but do you think it'd be possible to make/modify one of the integration tests such that it actually fails without your changes? The existing TestProtocol15Basics/BalanceIDs test passes without this change, which obviously led to a false sense of security in the feature's correctness, so it'd be good to have deeper validation for this fix in future test runs.
There was a problem hiding this comment.
this test will fail without my changes because the claimable balance operation source account is different from the transaction source account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
ClaimableBalanceID() builds an xdr.OperationId using the operation source account and the sequence number of the operation source account. It seems like we should be using the transaction source account and the sequence number found in the transaction. That is my understanding based on https://github.com/stellar/stellar-core/blob/b0cc4a9b8c3423358d1881b991834cf658bc38f5/src/transactions/CreateClaimableBalanceOpFrame.cpp#L278[…]L288
This fix was actually included in the v6 release #3393 . However, @leighmcculloch and @marcelosalloum would like to create a patch release for just this fix instead of including it in a major version release.
Known limitations
[N/A]