txnbuild: Make txnbuild create V1 transactions #2640
Conversation
tamirms
force-pushed
the
generate-v1
branch
2 times, most recently
from
7fa04a4
to
5f9cbba
Compare
| feeBumpTx, err := txnbuild.NewFeeBumpTransaction(txnbuild.FeeBumpTransactionParams{ | ||
| Inner: tx, | ||
| FeeAccount: feeBumpKP.Address(), | ||
| BaseFee: txnbuild.MinBaseFee * 2, | ||
| }) | ||
| feeBumpTx, err = feeBumpTx.Sign(network.TestNetworkPassphrase, feeBumpKP) |
There was a problem hiding this comment.
Do you skip checking these two errors on purpose? Same question to the below example.
There was a problem hiding this comment.
that is mistake, I'll push a fix
The XDR definition for v1 transaction envelopes and v0 transaction envelopes have different source account types. The source account field is represented as a
This is another feature that is partially introduced in protocol 13. https://github.com/stellar/stellar-protocol/blob/master/core/cap-0027.md has the full explanation |
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Currently,
txnbuildcreates v0 transaction envelopes which are accepted by both protocol 12 and protocol 13. In this PR, I have configuredtxnbuildto only create v1 transactions which will only be accepted once protocol 13 is enabled.This release should only be published after pubnet transitions to protocol 13. However, developers who would like to try out protocol 13 features in testnet such as fee bump transactions can use the txnbuild package from this PR to generate v1 transactions.
Why
It is not possible to create fee bump transactions using v0 transaction envelopes.
Known limitations
Once this PR is merged there will be no way to generate v0 transaction envelopes anymore. However, I don't think this is a big concern because we will only publish this release once protocol 13 is enabled.