Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NewSeq back to int64 in horizon response. #1616

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Aug 20, 2019

Reverting the change which fixes #1363 -- we'll introduce this breaking change in Horizon 0.22

Copy link
Contributor

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are you going to add the deprecation warnings to the changelog here, or in a separate PR?

@abuiles
Copy link
Contributor Author

abuiles commented Aug 20, 2019

@ire-and-curses I'll add it here. Incoming :)

Copy link
Contributor

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks great!

@abuiles abuiles merged commit 3879153 into release-horizon-v0.20.0 Aug 20, 2019
@abuiles abuiles deleted the undo-int64-to-string branch August 20, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants