txnbuild: function to verify sep10 challenge tx #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ire-and-curses
requested changes
Aug 8, 2019
txnbuild/transaction.go
Outdated
| return verifyTxSignature(tx, serverAccountId) | ||
| } | ||
|
|
||
| // verifyTxSignature checks if a transaction has been signed by the provided stellar account. |
ire-and-curses
approved these changes
Aug 9, 2019
txnbuild/transaction.go
Outdated
| maxTime := currentTime.Add(timebound) | ||
| txTimebound = NewTimebounds(currentTime.Unix(), maxTime.Unix()) | ||
| if timebound == 0 { | ||
| return "", errors.New("timebound can not be 0") |
There was a problem hiding this comment.
"cannot" is one word not two
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function
VerifyChallengeTxto the txnbuild package that verifies a SEP 10 challenge transaction according to the spec.This complements the
BuildChallengeTxfunction which builds a challenge transaction.This PR closes #1530