Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txnbuild: Expose signature envelope to caller #956

Closed
ire-and-curses opened this issue Feb 27, 2019 · 2 comments
Closed

txnbuild: Expose signature envelope to caller #956

ire-and-curses opened this issue Feb 27, 2019 · 2 comments
Labels
horizon txnbuild 2nd-generation transaction build library for Go SDK

Comments

@ire-and-curses
Copy link
Member

As was done in #716, allow the SDK caller to pass in an Envelope, for the case where keys are being managed externally.
@ire-and-curses ire-and-curses added horizon sdk txnbuild 2nd-generation transaction build library for Go SDK labels Feb 27, 2019
@ire-and-curses ire-and-curses changed the title Expose signature envelope to caller txnbuild: Expose signature envelope to caller Mar 20, 2019
@OwenJacob
Copy link
Contributor

Could initializing the transaction envelope be done at the end of build() rather than at the beginning of sign()?

OwenJacob added a commit to OwenJacob/go that referenced this issue Jun 7, 2019
@OwenJacob
Initialise transaction envelope in build
bbe7ea2 
Instead of building the transaction envelope at the start of Sign we can do this at the end of build. This allows an unsigned envelope to be returned for signing offline/elsewhere

Fix for: stellar#956
@OwenJacob OwenJacob mentioned this issue Jun 7, 2019
Merged
@ire-and-curses ire-and-curses mentioned this issue Jun 14, 2019
Closed
OwenJacob added a commit to OwenJacob/go that referenced this issue Jun 20, 2019
@OwenJacob
Initialise transaction envelope in build
10f8733 
Instead of building the transaction envelope at the start of Sign we can do this at the end of build. This allows an unsigned envelope to be returned for signing offline/elsewhere

Fix for: stellar#956
OwenJacob added a commit to OwenJacob/go that referenced this issue Jun 20, 2019
@OwenJacob
Initialise transaction envelope in build
c26d4a2 
Instead of building the transaction envelope at the start of Sign we can do this at the end of build. This allows an unsigned envelope to be returned for signing offline/elsewhere

Fix for: stellar#956
poliha pushed a commit that referenced this issue Jun 20, 2019
@OwenJacob @poliha
Initialise transaction envelope in build (#1376)
078fa57 
Instead of building the transaction envelope at the start of Sign we can do this at the end of build. This allows an unsigned envelope to be returned for signing offline/elsewhere

Fix for: #956
@poliha
Copy link
Contributor

poliha commented Jun 20, 2019

Closed in #1376

@poliha poliha closed this as completed Jun 20, 2019
oryband pushed a commit to kinecosystem/go that referenced this issue Jul 22, 2019
@OwenJacob @oryband
Initialise transaction envelope in build (stellar#1376)
68cd573 
Instead of building the transaction envelope at the start of Sign we can do this at the end of build. This allows an unsigned envelope to be returned for signing offline/elsewhere

Fix for: stellar#956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
horizon txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ire-and-curses @poliha @OwenJacob