Improve error boundary #1696
Merged
Improve error boundary #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
reviewed
Nov 22, 2024
| size="md" | ||
| onClick={() => { | ||
| // https://stackoverflow.com/questions/57854/how-can-i-close-a-browser-window-without-receiving-the-do-you-want-to-close-thi | ||
| window.open("", "_self", ""); |
piyalbasu
approved these changes
Nov 22, 2024
CassioMG
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1595
What
Makes the error boundary close in every scenario
Updates error boundary styles to not overflow header and better display error messages
Why
The navigation never works here because the error boundary sits at a higher level than the router.
Navigation patterns using the global navigation context don't work very well either because of the hash routing model so we would have to reload the window anyways.