[ANCHOR-810] Fix the rate response validation bug when there is no fee #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeUrban
reviewed
Sep 9, 2024
Comment on lines
-113
to
-116
| if (Objects.requireNonNull(rate).getFee() == null) { | ||
| logErrorAndThrow( | ||
| "'rate.fee' is missing in the GET /rate response", ServerErrorException.class); | ||
| } |
There was a problem hiding this comment.
Do we want to make the fee object optional?
There was a problem hiding this comment.
Its required in the SEP-38 responses
There was a problem hiding this comment.
Do we assume fee is necessary in a quote?
lijamie98
force-pushed
the
feature/anchor-810-validation-bug
branch
from
f71e317 to
94ecdc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
withinRoundingErrorcall was missing the!operator when there is nofeein the rate response.Context
Bub fix.
Testing
./gradlew testDocumentation
N/A
Known limitations
N/A