[ANCHOR-783] Remove amount_out requirement in RequestOffchainFunds #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipliu
force-pushed
the
fix/anchor-783-remove-amount-out
branch
from
b65e98d to
848f635
Compare
lijamie98
reviewed
Aug 23, 2024
lijamie98
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
amount_outis not set if a transaction has an associated indicative quote but has not yet received funds.Context
This was fixed for
RequestOnchainFundsalready.Testing
./gradlew testDocumentation
Will update stellar-docs
Known limitations
N/A