Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logs for SEP10Service #1023

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Aug 1, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

[TODO: Short statement about what is changing.]

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@Ifropc Ifropc requested a review from lijamie98 August 1, 2023 18:22
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@Ifropc Ifropc merged commit 61afb08 into legacy/core-release-1.0 Aug 1, 2023
@Ifropc Ifropc deleted the log-improvement branch August 1, 2023 20:29
Copy link
Collaborator

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ifropc Ifropc mentioned this pull request Aug 2, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants