Validate all Send Addresses against stellar.expert's list of maliciou…

…s/unsafe addresses (#245) * Validate all Send Addresses against stellar.expert's list of malicious/unsafe addresses * remove debugger * no need to remove space * forgot to remove ts nocheck * move flaggedAccounts to redux and address UI issues * Rename warning message component * only show "malicious" warning in case it's both "unsafe" && "malicious" * default to the localStorage and replace with API if applicable * matching error message spacing to createTransaction * update UI of warning messages * update stellar.expert url
stellar · Jan 11, 2021 · 4bac41e · 4bac41e
1 parent d544f30
commit 4bac41e
Show file tree

Hide file tree

Showing 13 changed files with 1,142 additions and 483 deletions.
diff --git a/package.json b/package.json
@@ -42,6 +42,10 @@
     "trezor-connect": "^8.1.16",
     "typescript": "~4.0.5"
   },
+  "resolutions": {
+    "**/@typescript-eslint/eslint-plugin": "^4.1.1",
+    "**/@typescript-eslint/parser": "^4.1.1"
+  },
   "scripts": {
     "install-if-package-changed": "git diff-tree -r --name-only --no-commit-id ORIG_HEAD HEAD | grep --quiet yarn.lock && yarn install || exit 0",
     "start": "react-scripts start",

diff --git a/src/components/BalanceInfo.tsx b/src/components/BalanceInfo.tsx
@@ -105,16 +105,18 @@ const WarningEl = styled.p`
 export const BalanceInfo = () => {
   const dispatch = useDispatch();
   const { account } = useRedux("account");
-  const { status, data, isAccountWatcherStarted } = account;
+  const { flaggedAccounts } = useRedux("flaggedAccounts");
+  const { status: accountStatus, data, isAccountWatcherStarted } = account;
+  const { status: flaggedAccountsStatus } = flaggedAccounts;
   const [isSendTxModalVisible, setIsSendTxModalVisible] = useState(false);
   const [isReceiveTxModalVisible, setIsReceiveTxModalVisible] = useState(false);
   const publicAddress = data.id;
 
   useEffect(() => {
-    if (status === ActionStatus.SUCCESS && !isAccountWatcherStarted) {
+    if (accountStatus === ActionStatus.SUCCESS && !isAccountWatcherStarted) {
       dispatch(startAccountWatcherAction(publicAddress));
     }
-  }, [dispatch, publicAddress, status, isAccountWatcherStarted]);
+  }, [dispatch, publicAddress, accountStatus, isAccountWatcherStarted]);
 
   let nativeBalance = 0;
 
@@ -146,7 +148,10 @@ export const BalanceInfo = () => {
                 logEvent("send: clicked start send");
               }}
               icon={<IconSend />}
-              disabled={data.isUnfunded}
+              disabled={
+                data.isUnfunded ||
+                flaggedAccountsStatus !== ActionStatus.SUCCESS
+              }
             >
               Send
             </Button>

diff --git a/src/components/SendTransaction/ConfirmTransaction.tsx b/src/components/SendTransaction/ConfirmTransaction.tsx
@@ -19,6 +19,8 @@ import { sendTxAction } from "ducks/sendTx";
 import { useRedux } from "hooks/useRedux";
 import { ActionStatus, AuthType, PaymentFormData } from "types/types.d";
 
+import { AccountIsUnsafe } from "./WarningMessages/AccountIsUnsafe";
+
 const TableEl = styled.table`
   width: 100%;
 
@@ -88,6 +90,10 @@ const InlineLoadingTextEl = styled.div`
   margin-left: 0.5rem;
 `;
 
+const WarningMessageEl = styled.div`
+  margin: 1.5rem 0 0.5rem;
+`;
+
 interface ConfirmTransactionProps {
   formData: PaymentFormData;
   maxFee: string;
@@ -205,6 +211,12 @@ export const ConfirmTransaction = ({
                 <span>{formData.toAccountId}</span>
               </AddressWrapperEl>
             </td>
+
+            {formData.isAccountUnsafe && (
+              <WarningMessageEl>
+                <AccountIsUnsafe />
+              </WarningMessageEl>
+            )}
           </tr>
           <tr>
             <th>Amount</th>

diff --git a/src/components/SendTransaction/CreateTransaction.tsx b/src/components/SendTransaction/CreateTransaction.tsx
@@ -29,6 +29,8 @@ import {
 import { PALETTE } from "constants/styles";
 import { knownAccounts } from "constants/knownAccounts";
 
+import { AccountIsUnsafe } from "./WarningMessages/AccountIsUnsafe";
+
 const RowEl = styled.div`
   display: flex;
   flex-wrap: wrap;
@@ -147,6 +149,11 @@ export const CreateTransaction = ({
     initialFormData.isAccountFunded,
   );
 
+  const [isAccountUnsafe, setIsAccountUnsafe] = useState(
+    initialFormData.isAccountUnsafe,
+  );
+  const [isAccountMalicious, setIsAccountMalicious] = useState(false);
+
   const knownAccount =
     knownAccounts[toAccountId] || knownAccounts[federationAddress || ""];
   const [prevAddress, setPrevAddress] = useState(
@@ -251,6 +258,24 @@ export const CreateTransaction = ({
     }
   };
 
+  const { flaggedAccounts } = useRedux("flaggedAccounts");
+
+  const checkIfAccountIsFlagged = (accountId: string) => {
+    const flaggedTags = flaggedAccounts.data.reduce(
+      (prev: string[], { address, tags }) => {
+        return address === accountId ? [...prev, ...tags] : prev;
+      },
+      [],
+    );
+    setIsAccountUnsafe(flaggedTags.includes("unsafe"));
+    setIsAccountMalicious(flaggedTags.includes("malicious"));
+  };
+
+  const resetAccountIsFlagged = () => {
+    setIsAccountUnsafe(false);
+    setIsAccountMalicious(false);
+  };
+
   const checkAndSetIsAccountFunded = async (accountId: string) => {
     if (!accountId || !StrKey.isValidEd25519PublicKey(accountId)) {
       setIsAccountFunded(true);
@@ -411,6 +436,7 @@ export const CreateTransaction = ({
         memoType,
         memoContent,
         isAccountFunded,
+        isAccountUnsafe,
       });
     }
   };
@@ -420,7 +446,9 @@ export const CreateTransaction = ({
       headlineText="Send Lumens"
       buttonFooter={
         <>
-          <Button onClick={onSubmit}>Continue</Button>
+          <Button disabled={isAccountMalicious} onClick={onSubmit}>
+            Continue
+          </Button>
           <Button onClick={onCancel} variant={ButtonVariant.secondary}>
             Cancel
           </Button>
@@ -464,6 +492,8 @@ export const CreateTransaction = ({
 
             // Reset all errors (to make sure unfunded account error is cleared)
             setInputErrors(initialInputErrors);
+
+            resetAccountIsFlagged();
           }}
           onBlur={(e) => {
             validate(e);
@@ -478,6 +508,7 @@ export const CreateTransaction = ({
 
             setPrevAddress(e.target.value);
             setIsAccountIdTouched(false);
+            checkIfAccountIsFlagged(e.target.value);
           }}
           error={inputErrors[SendFormIds.SEND_TO]}
           value={toAccountId}
@@ -515,6 +546,30 @@ export const CreateTransaction = ({
         </RowEl>
       )}
 
+      {isAccountUnsafe && !isAccountMalicious && (
+        <RowEl>
+          <AccountIsUnsafe />
+        </RowEl>
+      )}
+      {isAccountMalicious && (
+        <RowEl>
+          <InfoBlock variant={InfoBlockVariant.error}>
+            <p>
+              The account you’re sending to is tagged as{" "}
+              <strong>#malicious</strong> on{" "}
+              <a
+                href="https://stellar.expert/directory"
+                target="_blank"
+                rel="noopener noreferrer"
+              >
+                stellar.expert’s directory
+              </a>
+              . For your safety, sending to this account is disabled.
+            </p>
+          </InfoBlock>
+        </RowEl>
+      )}
+
       <RowEl>
         <CellEl>
           <Input

diff --git a/src/components/SendTransaction/SendTransactionFlow.tsx b/src/components/SendTransaction/SendTransactionFlow.tsx
@@ -25,6 +25,7 @@ const initialFormData: PaymentFormData = {
   memoType: MemoNone,
   memoContent: "",
   isAccountFunded: true,
+  isAccountUnsafe: false,
 };
 
 export const SendTransactionFlow = ({ onCancel }: { onCancel: () => void }) => {

diff --git a/src/components/SendTransaction/WarningMessages/AccountIsUnsafe.tsx b/src/components/SendTransaction/WarningMessages/AccountIsUnsafe.tsx
@@ -0,0 +1,19 @@
+import React from "react";
+
+import { InfoBlock, InfoBlockVariant } from "components/basic/InfoBlock";
+
+export const AccountIsUnsafe = () => (
+  <InfoBlock variant={InfoBlockVariant.warning}>
+    <p>
+      The account you’re sending to is tagged as <strong>#unsafe</strong> on{" "}
+      <a
+        href="https://stellar.expert/directory"
+        target="_blank"
+        rel="noopener noreferrer"
+      >
+        stellar.expert’s directory
+      </a>
+      . Proceed with caution.
+    </p>
+  </InfoBlock>
+);
diff --git a/src/config/store.ts b/src/config/store.ts
@@ -11,6 +11,7 @@ import BigNumber from "bignumber.js";
 import { RESET_STORE_ACTION_TYPE } from "constants/settings";
 
 import { reducer as account } from "ducks/account";
+import { reducer as flaggedAccounts } from "ducks/flaggedAccounts";
 import { reducer as keyStore } from "ducks/keyStore";
 import { reducer as sendTx } from "ducks/sendTx";
 import { reducer as settings } from "ducks/settings";
@@ -36,6 +37,7 @@ const isSerializable = (value: any) =>
 
 const reducers = combineReducers({
   account,
+  flaggedAccounts,
   keyStore,
   sendTx,
   settings,

diff --git a/src/constants/settings.ts b/src/constants/settings.ts
@@ -3,6 +3,8 @@ import StellarSdk from "stellar-sdk";
 export const TX_HISTORY_LIMIT = 100;
 export const TX_HISTORY_MIN_AMOUNT = 0.5;
 export const RESET_STORE_ACTION_TYPE = "RESET";
+export const FLAGGED_ACCOUNT_STORAGE_ID = "flaggedAcounts";
+export const FLAGGED_ACCOUNT_DATE_STORAGE_ID = "flaggedAcountDate";
 
 interface NetworkItemConfig {
   url: string;

diff --git a/src/ducks/flaggedAccounts.ts b/src/ducks/flaggedAccounts.ts
@@ -0,0 +1,68 @@
+import { createAsyncThunk, createSlice } from "@reduxjs/toolkit";
+
+import {
+  FLAGGED_ACCOUNT_STORAGE_ID,
+  FLAGGED_ACCOUNT_DATE_STORAGE_ID,
+} from "constants/settings";
+import { getFlaggedAccounts } from "helpers/getFlaggedAccounts";
+import { ActionStatus, FlaggedAccounts } from "types/types.d";
+
+const initialState: FlaggedAccounts = {
+  data: [{ address: "", tags: [""] }],
+  status: undefined,
+};
+
+export const fetchFlaggedAccountsAction = createAsyncThunk(
+  "action/fetchFlaggedAccountsAction",
+  async () => {
+    let accounts;
+    const date = new Date();
+    const time = date.getTime();
+    const sevenDaysAgo = time - 7 * 24 * 60 * 60 * 1000;
+    const flaggedAccountsCacheDate = Number(
+      localStorage.getItem(FLAGGED_ACCOUNT_DATE_STORAGE_ID),
+    );
+
+    accounts = JSON.parse(
+      localStorage.getItem(FLAGGED_ACCOUNT_STORAGE_ID) || "[]",
+    );
+
+    // if flaggedAccounts were last cached over seven days ago, make the request
+    // flaggedAccountsCacheDate is coerced to 0 if not found in storage
+    if (flaggedAccountsCacheDate < sevenDaysAgo) {
+      try {
+        accounts = await getFlaggedAccounts();
+        // store the accounts plus the date we've acquired them
+        localStorage.setItem(
+          FLAGGED_ACCOUNT_STORAGE_ID,
+          JSON.stringify(accounts),
+        );
+        localStorage.setItem(FLAGGED_ACCOUNT_DATE_STORAGE_ID, time.toString());
+      } catch (e) {
+        console.error("Flagged account API did not respond");
+      }
+    }
+
+    return accounts;
+  },
+);
+
+const flaggedAccountsSlice = createSlice({
+  name: "flaggedAccounts",
+  initialState,
+  reducers: {},
+  extraReducers: (builder) => {
+    builder.addCase(
+      fetchFlaggedAccountsAction.pending,
+      (state = initialState) => {
+        state.status = ActionStatus.PENDING;
+      },
+    );
+    builder.addCase(fetchFlaggedAccountsAction.fulfilled, (state, action) => {
+      state.status = ActionStatus.SUCCESS;
+      state.data = action.payload;
+    });
+  },
+});
+
+export const { reducer } = flaggedAccountsSlice;
diff --git a/src/helpers/getFlaggedAccounts.ts b/src/helpers/getFlaggedAccounts.ts
@@ -0,0 +1,24 @@
+const UNSAFE_ACCOUNTS_URL =
+  "https://api.stellar.expert/explorer/directory?limit=20000000&tag[]=malicious&tag[]=unsafe";
+// setting limit very high as there doesn't appear to be a better way to get all entries from API
+const RESPONSE_TIMEOUT = 5000;
+// if API doesn't respond in this amount of time, we'll cancel the request
+
+export const getFlaggedAccounts = async () => {
+  const controller = new AbortController();
+  const timeoutId = setTimeout(() => controller.abort(), RESPONSE_TIMEOUT);
+
+  const flaggedAccountsRes = await fetch(UNSAFE_ACCOUNTS_URL, {
+    signal: controller.signal,
+  });
+  clearTimeout(timeoutId);
+  const flaggedAccountsJson = await flaggedAccountsRes.json();
+
+  const {
+    _embedded: { records: unsafeAccountsData },
+  } = flaggedAccountsJson;
+
+  return unsafeAccountsData.map(
+    ({ address, tags }: { address: string; tags: [] }) => ({ address, tags }),
+  );
+};
diff --git a/src/pages/Dashboard.tsx b/src/pages/Dashboard.tsx
@@ -1,17 +1,21 @@
 import React, { useEffect } from "react";
+import { useDispatch } from "react-redux";
 import styled from "styled-components";
 import { BalanceInfo } from "components/BalanceInfo";
 import { TransactionHistory } from "components/TransactionHistory";
 import { logEvent } from "helpers/tracking";
+import { fetchFlaggedAccountsAction } from "ducks/flaggedAccounts";
 
 const WrapperEl = styled.div`
   width: 100%;
 `;
 
 export const Dashboard = () => {
+  const dispatch = useDispatch();
   useEffect(() => {
+    dispatch(fetchFlaggedAccountsAction());
     logEvent("page: saw account main screen");
-  }, []);
+  }, [dispatch]);
 
   return (
     <WrapperEl>

diff --git a/src/types/types.d.ts b/src/types/types.d.ts
@@ -67,6 +67,16 @@ export interface AccountInitialState {
   errorString?: string;
 }
 
+interface FlaggedAccount {
+  address: string;
+  tags: string[];
+}
+
+export interface FlaggedAccounts {
+  data: [FlaggedAccount];
+  status: ActionStatus | undefined;
+}
+
 export interface KeyStoreInitialState {
   keyStoreId: string;
   password: string;
@@ -107,6 +117,7 @@ export interface WalletInitialState {
 
 export interface Store {
   account: AccountInitialState;
+  flaggedAccounts: FlaggedAccounts;
   keyStore: KeyStoreInitialState;
   knownAccounts: KnownAccountsInitialState;
   sendTx: SendTxInitialState;
@@ -141,4 +152,5 @@ export interface PaymentFormData {
   memoType: MemoType;
   memoContent: MemoValue;
   isAccountFunded: boolean;
+  isAccountUnsafe: boolean;
 }