Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary escape #57

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

wxt2005
Copy link
Contributor

@wxt2005 wxt2005 commented Apr 3, 2020

GitHub Action will never actually set output result with the escaped quote, and ${{steps.<step_id>.outputs.changes_detected}} will always be null.

You could check the difference from the debug log between the current version and my fork.

Current Version
https://github.com/bangumi-data/bangumi-data/runs/557011365?check_suite_focus=true
image

Forked Version
https://github.com/bangumi-data/bangumi-data/runs/557156710?check_suite_focus=true
image

@stefanzweifel
Copy link
Owner

Thanks!

@stefanzweifel stefanzweifel merged commit 5573440 into stefanzweifel:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants