[4.0] Switch to NodeJS Environment (BC) #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the action to use the
node12
-environment instead ofDocker
. The Action therefore uses the default Actions environment and has access to all the installed software.For example, it's now possible to run pre-commit hooks with husky (Closes #18).
I've decided against using packages like
@actions/exec
and@actions/toolkit
, as I don't like the overhead of installing node packages just to execute a shell script. The code to execute a shell script via node has been inspired by https://github.com/ad-m/github-push-action/.The next logical step would be to rewrite the shell script in JS or TS. See #44.
Testing
To the the changes, please update your workflow file to use the
refactor/switch-to-js
-branch of the repo.Test Run: