Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Switch to NodeJS Environment (BC) #45

Merged
merged 10 commits into from
Feb 24, 2020
Merged

Conversation

stefanzweifel
Copy link
Owner

This PR rewrites the action to use the node12-environment instead of Docker. The Action therefore uses the default Actions environment and has access to all the installed software.

For example, it's now possible to run pre-commit hooks with husky (Closes #18).

I've decided against using packages like @actions/exec and @actions/toolkit, as I don't like the overhead of installing node packages just to execute a shell script. The code to execute a shell script via node has been inspired by https://github.com/ad-m/github-push-action/.

The next logical step would be to rewrite the shell script in JS or TS. See #44.

Testing

To the the changes, please update your workflow file to use the refactor/switch-to-js-branch of the repo.

    - uses: stefanzweifel/git-auto-commit-action@refactor/switch-to-js
      with:
        commit_message: Your Message goes here
        branch: ${{ github.head_ref }}

Test Run:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't find node in PATH, trying to find a node binary on your system
1 participant