Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make branch option optional #41

Merged
merged 12 commits into from
Feb 6, 2020
Merged

Conversation

stefanzweifel
Copy link
Owner

@stefanzweifel stefanzweifel commented Feb 6, 2020

This PR updates the _push_to_github-function and the call to git push to make the branch input option optional.

If no branch name has been given, we now just execute git push origin without an explicit branch name.


I've tested this with actions/checkouts@v2 and with Workflows listening to the push event, and it works great.


Closes #27

@stefanzweifel stefanzweifel self-assigned this Feb 6, 2020
@stefanzweifel stefanzweifel linked an issue Feb 6, 2020 that may be closed by this pull request
@OskarStark
Copy link
Contributor

Proud that my action is used 🥰

@stefanzweifel
Copy link
Owner Author

@OskarStark I use php-cs-fixer-ga basically in every PHP repo I touch ♥️

@OskarStark
Copy link
Contributor

Thank you 🥳✌🏻

@stefanzweifel stefanzweifel merged commit 1d39bb6 into v3 Feb 6, 2020
@stefanzweifel stefanzweifel deleted the feature/make-branch-optional branch February 6, 2020 19:51
@stefanzweifel stefanzweifel mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make branch optional
2 participants