Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Git-LFS while building Dockerfile #21

Merged

Conversation

jkaan
Copy link
Contributor

@jkaan jkaan commented Nov 30, 2019

Hi there!

As we discussed, the PR to install git-lfs while building the Dockerfile :). Let me know if you would like me to change commit messages or something

@jkaan jkaan force-pushed the feature/add-support-for-lfs branch from fc0ccab to 44a415d Compare November 30, 2019 12:09
@stefanzweifel
Copy link
Owner

Thanks 👍

Have you tested the changes in a repository? We don't have a test suite (yet).

@stefanzweifel stefanzweifel self-requested a review November 30, 2019 12:15
@jkaan
Copy link
Contributor Author

jkaan commented Nov 30, 2019

@stefanzweifel I have not actually, how can I easily do that?

@stefanzweifel
Copy link
Owner

You can use your fork by adding the following code to a workflow of yours:

- uses: jkaan/git-auto-commit-action@feature/add-support-for-lfs
  with:
    commit_message: Apply automatic changes
    branch: ${{ github.head_ref }}
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

I will test it too, just wanted to ask if you did any tests yet :)

@jkaan
Copy link
Contributor Author

jkaan commented Nov 30, 2019

I've just tried it on a project of mine which has LFS enabled and it worked :).

@stefanzweifel stefanzweifel merged commit 8db04fa into stefanzweifel:master Nov 30, 2019
@stefanzweifel
Copy link
Owner

I also tested it in a repo without LFS. Works great. Will merge to master and tag a new version soon.

@stefanzweifel stefanzweifel removed their request for review November 30, 2019 18:38
@stefanzweifel stefanzweifel mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants