Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a default commit message if one isn't provided #103

Closed
fregante opened this issue Oct 4, 2020 · 2 comments · Fixed by #110
Closed

Use a default commit message if one isn't provided #103

fregante opened this issue Oct 4, 2020 · 2 comments · Fixed by #110
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fregante
Copy link

fregante commented Oct 4, 2020

Is your feature request related to a problem? Please describe.

Currently commit_message is a required input. Given how verbose workflows can be, I prefer not having to specify any inputs when possible.

Describe the solution you'd like

If commit_message isn't specified, it should use a default message. Anything generic works. The "Apply automatic changes" message suggested by the readme would also be fine.

I'm open to submit a PR for this.

@stefanzweifel
Copy link
Owner

The idea behind this, is that you can simply add this line to your workflows and be done with it, right?

- uses: stefanzweifel/git-auto-commit-action@v4

I think thats actually not a bad idea. "Apply automatic changes" might be a good starting point.
However I would like to encurage users in the README to set their own value.

Feel free to PR this.
Updating the following lines accordingly should do the trick:
https://github.com/stefanzweifel/git-auto-commit-action/blob/master/action.yml#L7-L9

@stefanzweifel stefanzweifel added enhancement New feature or request good first issue Good for newcomers labels Oct 9, 2020
stefanzweifel added a commit that referenced this issue Oct 11, 2020
Make commit_message optional #103
@stefanzweifel stefanzweifel linked a pull request Oct 11, 2020 that will close this issue
@stefanzweifel
Copy link
Owner

Has been implemented in #110.
I will tag a new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants