Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for bundles with local modules #355

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Add tests for bundles with local modules #355

merged 1 commit into from
Mar 2, 2024

Conversation

stefanprodan
Copy link
Owner

Followup: #348

@stefanprodan stefanprodan force-pushed the test-bundle-local branch 2 times, most recently from bf15900 to 4f7e3fd Compare March 2, 2024 12:20
@stefanprodan stefanprodan added the area/bundles Timoni's Bundle related issues and pull requests label Mar 2, 2024
@stefanprodan stefanprodan force-pushed the test-bundle-local branch 2 times, most recently from 1d36541 to a279870 Compare March 2, 2024 12:53
b4nst
b4nst approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@b4nst b4nst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/engine/bundle_builder.go Outdated Show resolved Hide resolved
@stefanprodan stefanprodan merged commit 5f4dd1a into main Mar 2, 2024
5 checks passed
@stefanprodan stefanprodan deleted the test-bundle-local branch March 2, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b4nst b4nst b4nst approved these changes

Assignees
No one assigned
Labels
area/bundles Timoni's Bundle related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @b4nst