feat: add YAML and JSON support for bundles #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @stefanprodan, just added JSON support and a test case with the combo of all file types. |
|
Thanks @b4nst can you please rebase with main, solve conflicts and force push to unblock CI. |
stefanprodan
added
enhancement
stefanprodan
changed the title
|
Of course! Sorry I went a bit fast on the push 😅 |
b4nst
force-pushed
the
feat/support-yaml-bundle-files
branch
from
5edc239 to
06298a6
Compare
|
Ok rebased, seems there's an issue with the Copy and YAML files during workspace creation introduced with the injection system (break the content of the file). I'll give it a look |
|
@b4nst I suggest we put in the workspace not the jsons and yamls but their cue value. |
|
Yup, that's what I started (moving the extract part into the workspace function). Incoming today |
b4nst
force-pushed
the
feat/support-yaml-bundle-files
branch
from
06298a6 to
8894bc2
Compare
stefanprodan
reviewed
Jul 6, 2023
b4nst
force-pushed
the
feat/support-yaml-bundle-files
branch
3 times, most recently
from
b8f7959 to
a40a1fb
Compare
hiddeco
reviewed
Jul 6, 2023
b4nst
force-pushed
the
feat/support-yaml-bundle-files
branch
from
a40a1fb to
3b6568b
Compare
hiddeco
reviewed
Jul 6, 2023
b4nst
force-pushed
the
feat/support-yaml-bundle-files
branch
from
3b6568b to
6c51f9e
Compare
|
Is it good to merge @stefanprodan? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little addition add YAML support for bundle file. It can be useful for multiple purposes, like using
sopsencrypted files until we address #74.I'm also referencing cue-lang/cue/discussions/2452 in case a better way of including Orphan files exists.