Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

Use AWS cli when available #121

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Conversation

endrec
Copy link
Contributor

@endrec endrec commented Oct 19, 2020

This PR

  • updates Azure CLI
  • adds AWS CLI to docker
  • adds kmsKeyId and storageClass options to S3 plan
  • changes pkg/backup/s3.go to use AWS cli for AWS S3 (if it's available in the docker image)

Fixes #81, as AWS cli natively uses IAM role, or any other available authentication mechanism (e.g. service role).

Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @endrec

@stefanprodan stefanprodan merged commit 1a40e5a into stefanprodan:master Oct 19, 2020
@endrec
Copy link
Contributor Author

endrec commented Oct 19, 2020

@stefanprodan Would it be possible to make this a release?

@endrec endrec deleted the aws-cli branch October 19, 2020 15:30
@stefanprodan
Copy link
Owner

Release is on Docker Hub: stefanprodan/mgob:1.2

@endrec
Copy link
Contributor Author

endrec commented Oct 19, 2020

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support to use AWS IAM role
2 participants