[Fixes #336] Promise.prototype.finally must not fail for a non-callable callback #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for letting this linger, I was out sick the past few days. |
|
released as v4.2.5 🎉 |
|
I'm going to back-port this to RSVP.js as well, thanks again! |
stefanpenner
added a commit
to tildeio/rsvp.js
that referenced
this pull request
Sep 10, 2018
Turbo87
pushed a commit
to ember-cli/ember-cli-eslint
that referenced
this pull request
Oct 15, 2018
Bumps [rsvp](https://github.com/tildeio/rsvp.js) from 4.7.0 to 4.8.4. <details> <summary>Changelog</summary> *Sourced from [rsvp's changelog](https://github.com/tildeio/rsvp.js/blob/master/CHANGELOG.md).* > # Master > > # 4.8.2 > > * restore cast for 4.x > > # 4.8.1 > > * Confuse Webpack (make is easier to pack this module) > > # 4.8.0 > > * reject promise when non-array promise is passed to RSVP.filter > * fix issue with registering event callbacks > * remove publishing to S3 and rely on `npm` and `jsdelivr.com` instead > * general cleanup </details> <details> <summary>Commits</summary> - [`ac50a0a`](tildeio/rsvp.js@ac50a0a) release v4.8.4 🎉 - [`9be07de`](tildeio/rsvp.js@9be07de) port [**codeworrior**](https://github.com/codeworrior)'s stefanpenner/es6-promise#339 - [`1ba4bf7`](tildeio/rsvp.js@1ba4bf7) Merge pull request [#536](https://github-redirect.dependabot.com/tildeio/rsvp.js/issues/536) from xg-wang/master - [`eb5bd44`](tildeio/rsvp.js@eb5bd44) fix backtick - [`bcd0936`](tildeio/rsvp.js@bcd0936) Merge pull request [#535](https://github-redirect.dependabot.com/tildeio/rsvp.js/issues/535) from michga/patch-1 - [`beae443`](tildeio/rsvp.js@beae443) typo - [`879fe32`](tildeio/rsvp.js@879fe32) release v4.8.3 🎉 - [`f81b8d4`](tildeio/rsvp.js@f81b8d4) Merge pull request [#534](https://github-redirect.dependabot.com/tildeio/rsvp.js/issues/534) from bekzod/update-libs - [`d306869`](tildeio/rsvp.js@d306869) bump deps - [`238f66b`](tildeio/rsvp.js@238f66b) Merge pull request [#495](https://github-redirect.dependabot.com/tildeio/rsvp.js/issues/495) from bekzod/align-things - Additional commits viewable in [compare view](tildeio/rsvp.js@v4.7.0...v4.8.4) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=rsvp&package-manager=npm_and_yarn&previous-version=4.7.0&new-version=4.8.4) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. Dependabot will **not** automatically merge this PR because it includes a minor update to a production dependency. --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
This was referenced Nov 6, 2018
This was referenced Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.