Promise.prototype.finally [fixes #232]

[stefanpenner]

No description provided.

[stefanpenner]

@ljharb should I wait until stage 3?

[ljharb]

Officially yes, but at this point I do not anticipate changes prior to stage 3 that would affect this PR.

Take that with the appropriate grains of salt :-)

[eLarocque]

Hey guys.
Wondering what the update is on this since the finally promise is in stage 3.
https://github.com/tc39/proposals/blob/master/README.md

There a chance we will see an merge in near future?
Thanks

[ljharb]

So far this looks great; two comments, and then there's actually a difference with Promise.resolve in the spec and here, which is that this one returns the promise unchanged when it's a base Promise and finally's does not - that might end up changing tho.

[ljharb]

onFinally is the name in the spec

[ljharb]

this needs to use Symbol.species to look up the constructor

[stefanpenner]

We don't currently support species stuff here.

[l1bbcsg]

Any updates on this? finally has hit stage 3 several moths ago now.

Also I'd like to remind you that just like catch this creates problems in browsers not compliant with ES5 allowing reserved words to be used as property names.
Assuming build process handles that and will quote it just like 'catch', it's worth noting in the readme at least.

[stefanpenner]

Any updates on this? finally has hit stage 3 several moths ago now.

Thanks for the reminder! I have also been eager to land this. Taking a look now.

Also I'd like to remind you that just like catch this creates problems in browsers not compliant with ES5 allowing reserved words to be used as property names.
Assuming build process handles that and will quote it just like 'catch', it's worth noting in the readme at least.

• Yup the build handles this correctly
• I'll add an additional snippet to: https://github.com/stefanpenner/es6-promise#usage-in-ie9

[stefanpenner]

@l1bbcsg updated, waiting for CI to complete

[ljharb]

Seems legit; modulo Symbol.species stuff