-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation around ancestry field and collation #607
Improve documentation around ancestry field and collation #607
Conversation
@kshnurov I updated the gem to use Staying with the original comments, but put in more documentation to hopefully get this running correctly. |
Ok, after some digging it turns out postgres returns
With this one, tests are green unless we use Another solution is to call |
c5de07d
to
c1a253c
Compare
@kshnurov For a binary ancestry column, what else do I need to specify to set a length? And what value should I use?
|
IDK if you missed this comment |
c1a253c
to
1d62cd4
Compare
Since this is used in all tests, best to cache this
1d62cd4
to
394ff38
Compare
postgres: binary data type is not currently working mysql: binary data type or string with binary collation is working Had wanted to go with binary for all, but test would not pass
394ff38
to
18ad23e
Compare
update:
|
* Fix: descendants ancestry is now updated in after_update callbacks stefankroes#589 * Document updated grammar stefankroes#594 * Documented `update_strategy` stefankroes#588 * Fix: fixed has_parent? when non-default primary id stefankroes#585 * Documented column collation and testing stefankroes#601 stefankroes#607 * Added initializer with default_ancestry_format stefankroes#612 * ruby 3.2 support stefankroes#596
* Fix: materialized_path2 strategy stefankroes#597 * Fix: descendants ancestry is now updated in after_update callbacks stefankroes#589 * Document updated grammar stefankroes#594 * Documented `update_strategy` stefankroes#588 * Fix: fixed has_parent? when non-default primary id stefankroes#585 * Documented column collation and testing stefankroes#601 stefankroes#607 * Added initializer with default_ancestry_format stefankroes#612 * ruby 3.2 support stefankroes#596
* Fix: materialized_path2 strategy stefankroes#597 * Fix: descendants ancestry is now updated in after_update callbacks stefankroes#589 * Document updated grammar stefankroes#594 * Documented `update_strategy` stefankroes#588 * Fix: fixed has_parent? when non-default primary id stefankroes#585 * Documented column collation and testing stefankroes#601 stefankroes#607 * Added initializer with default_ancestry_format stefankroes#612 * ruby 3.2 support stefankroes#596
dependency:
postgres: binary data type is not currently working
mysql: binary data type or string with binary collation is working
Had wanted to go with a binary for all database, but the test would not pass.
So I backtracked a little, researched opclasses, preferring ascii where possible.
This updates the comments introduced in #601