Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased #564 with Ruby 3.1 support and updated CI #577

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Rebased #564 with Ruby 3.1 support and updated CI #577

merged 3 commits into from
Jun 9, 2022

Conversation

petergoldstein
Copy link
Contributor

This is a rebased version of #564 .

In addition to the rebase it includes:

  1. Changes to the GitHub Actions file to run Rails 7 / Ruby 3.1 in the CI matrix
  2. Changes to test/environment.rb to support database.ci.yml file loading in Psych 4 (by explicitly enabling aliases)
  3. Removing the now unused .travis.yml, since there's no reason to keep that in sync.

I'm not sure why the VERSION value was bumped in the original PR, but I've left it as it was in the original PR.

@petergoldstein
Copy link
Contributor Author

This runs green on my fork.

@kbrock
Copy link
Collaborator

kbrock commented Jun 9, 2022

Just to be clear, we are expecting that rails 7.0 may fail.
But we want the failure to be there so we can fix it?

UPDATE: looks like it was green

@kbrock kbrock merged commit ae24dad into stefankroes:master Jun 9, 2022
@kbrock kbrock mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants