Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in test suite running on windows #114

Open
ghost opened this issue Aug 12, 2014 · 5 comments
Open

Issue in test suite running on windows #114

ghost opened this issue Aug 12, 2014 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Aug 12, 2014

Trying to run this on a windows machine but getting the following:

$ grunt
Running "clean:tests" (clean) task

Running "nodeunit:tests" (nodeunit) task
Testing phantomasTest.js.......F..........F.............

phantomas - constructor
Error: 'tmp\data' === 'tmp/data/'
at Object.exports.phantomas.constructor (test\lib\phantomasTest.js:310:10)
at Object.exports.phantomas.setUp (test\lib\phantomasTest.js:293:5)

phantomas - constructor
Error: 'tmp\images' === 'tmp/images/'
at Object.exports.phantomas.constructor (test\lib\phantomasTest.js:313:10)
at Object.exports.phantomas.setUp (test\lib\phantomasTest.js:293:5)

phantomas - getImages - imagesExist
Error: ENOENT, no such file or directory 'c:\Users\xxxxxxx\node_modules\grunt-phantomas\tmp\images\123456\screenshot-2014-06-28T12:40:29-1000.png
at Object.fs.openSync (fs.js:432:18)
at Object.fs.writeFileSync (fs.js:971:15)
at Object.exports.phantomas.getImages.imagesExist (test\lib\phantomasTest.js:599:10)
at Object.exports.phantomas.setUp (test\lib\phantomasTest.js:293:5)

Warning: 3/96 assertions failed (27290ms) Use --force to continue.

Aborted due to warnings.

@stefanjudis
Copy link
Owner

:)

Does the phantomas task $ grunt phantomas work as expected? Or is only the test suite failing?

The fix about this is usually to wrap all UNIX-like paths into an path.normalize, to adjust the directory seperators to given system.

If you could investigate and check if this solves it, it would be great, because I've got no windows machine available.

Pull Requests are more than welcome. :bowtie:

@ghost
Copy link
Author

ghost commented Aug 12, 2014

$ grunt phantomas does work. I'll try path.normalize for the test suite as soon as i can and post results.
Thanks!

@stefanjudis
Copy link
Owner

Thanks for investigating. :)

@stefanjudis stefanjudis changed the title Issue running on windows Issue in test suite running on windows Aug 12, 2014
@stefanjudis
Copy link
Owner

@DevilMike any news here?

@ghost
Copy link
Author

ghost commented Sep 4, 2014

Sorry, been crazy busy. Will test asap.

@stefanjudis stefanjudis added this to the v0.11.0 milestone Sep 7, 2014
@stefanjudis stefanjudis removed this from the v0.11.0 milestone Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant