Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabError #13

Open
reedjosh opened this issue Oct 13, 2017 · 7 comments
Open

TabError #13

reedjosh opened this issue Oct 13, 2017 · 7 comments

Comments

@reedjosh
Copy link

The file /src/pplatex/site_scons/envhelper.py is auto generated and it appears to use an inconsistent tab/spacing scheme. As such, I can't build the package.

Of course it's quite likely I'm just missing something. Please let me know.

Thanks!

neingeist added a commit to neingeist/pplatex that referenced this issue Jan 7, 2018
Using SCons 3 means using Python 3, which is pickier about mixed tab
and space indenting and using the print() function instead of the print
statement. Also relative imports have changed.

Fix this by indenting with spaces only and using the print() function
(using "from __future__ import print_function"). Additionally, fix
relative imports.

Fixes issue stefanhepp#13.
@neingeist
Copy link
Contributor

@reedjosh https://github.com/neingeist/pplatex master has the fix

@schaetzc
Copy link

schaetzc commented Sep 3, 2019

Thank you neingeist for the fix. Works for me. I would be happy to see your fix being pulled.

To the readers trying to build this project without using the fork:
The cmake build process still works. See https://github.com/stefanhepp/pplatex/blob/master/CMakeLists.txt for instructions. However, the resulting binaries were written to the src directory.

@Aster89
Copy link

Aster89 commented Oct 12, 2019

Hello @schaetzc . I was trying to install pplatex by makepgk -si on Arch, and I got the same error. So I searched for info on the AUR page of pplatex and found your message. There you mention the same two solutions you mention here. Can you please help understand the following about each of them?

  1. I used to install AUR packages by makepkg -si after "naively" checking there's nothing bad in the PKGBUILD file; however the suggested fork https://github.com/neingeist/pplatex is not an AUR package (is it?), so how should I install it properly on ArchLinux?
  2. If I was to choose the second solution, you suggest to change build() and then also to change bin to src in package(); however you only write Replace all install … bin/pplatex with install … src/pplatex, while those two lines have another instance of bin, in the part you shortended in ... (the lines are indeed install -Dm755 bin/pplatex "$pkgdir/usr/bin/pplatex" and install -Dm755 bin/ppluatex "$pkgdir/usr/bin/ppluatex"). Should I substitute only the second occurrence of bin or also the first one?

I'm sorry if my questions are a bit dumb, but I am not that confident about my understanding of the installation process.

@schaetzc
Copy link

schaetzc commented Oct 12, 2019

@Aster89 I think it would be better to discuss this in AUR as this project. Anyways, here are your answers:

  1. An AUR "package" is just the script PKGBUILD. The script downloads sources from somewhere else, builds, and installs them. If you edit PKGBUILD and replace url="https://github.com/stefanhepp/pplatex" with url="https://github.com/neingeist/pplatex " you basically created your own AUR package for neingeist's fork. This new "package" should build just fine.
  2. I think the function should be as follows. However, I'm short on time and could neither test it nor think about it too much.
package() {
  cd "$srcdir/$_pkgname"
  install -Dm755 src/pplatex "$pkgdir/usr/bin/pplatex"
  ln -s pplatex "$pkgdir/usr/bin/ppdflatex"
  install -Dm755 src/ppluatex "$pkgdir/usr/bin/ppluatex"
}

@Aster89
Copy link

Aster89 commented Oct 12, 2019

When you write I think it would be better to discuss this in AUR as this project are you saying I should comment at the page of the first link in my previous message?

However thank you for your explanation! :)

However for some reason I get the same error after changing the url variable.

@schaetzc
Copy link

schaetzc commented Oct 12, 2019

are you saying I should comment at the page of the first link in my previous message?

Yes.

However for some reason I get the same error after changing the url variable.

Oops. You probably have to change source=("git+https://github.com/stefanhepp/$_pkgname.git") to neingeist's repo too. Also, to play it safe, delete the downloaded repos from previous builds before building again.

@stefanhepp
Copy link
Owner

Thanks for all your comments - I finally merged neingeist's pull request, so the tab problem with Python3 should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants