Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampersands in URL parameters incorrectly handled #34

Closed
Tom-Lovatt opened this issue Aug 19, 2021 · 3 comments
Closed

Ampersands in URL parameters incorrectly handled #34

Tom-Lovatt opened this issue Aug 19, 2021 · 3 comments

Comments

@Tom-Lovatt
Copy link

Tom-Lovatt commented Aug 19, 2021

Steps to reproduce:

  1. Add a URL parameter with a (correctly-encoded) ampersand to page 1 E.g /songs/?genre=Rock%26Roll
  2. Navigate to page 2

Expected behaviour:
The URL is now /songs/?genre=Rock%26Roll&page=2
Which will be parsed as genre=Rock&Roll, page=2

Actual behaviour:
The URL is now /users/?genre=Rock&Roll&page=2
Which will be parsed as genre=Rock, Roll=, page=2

It looks like it's caused by the call to urldecode() in Zebra_Pagination.php:903, but I'm not sure what side-effects removing that would cause.

stefangabos added a commit that referenced this issue Sep 2, 2021
@stefangabos
Copy link
Owner

Thank you for reporting this
I made a fix. I'd really appreciate it if you could validate that it works
Thanks!

@Tom-Lovatt
Copy link
Author

That fixes it, thanks!

@stefangabos
Copy link
Owner

Thanks for testing it!
I published a new version with this fix included.
Thanks again for reporting and for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants