Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolve PhoneNumberInternationalWidget to RegionalPhoneNumberWidget #529

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

francoisfreitag
Copy link
Collaborator

@francoisfreitag francoisfreitag commented Aug 31, 2022

Instead of hardcoding the INTERNATIONAL format, follow the
PHONENUMBER_DEFAULT_FORMAT preference (defaulting to E164).

The PhoneNumberInternationalWidget is now deprecated and will be removed
in the next major version. Use PhoneNumberWithFallbackWidget with
setting PHONENUMBER_DEFAULT_FORMAT="INTERNATIONAL" instead.

@francoisfreitag francoisfreitag changed the title Improve PhoneNumberInternationalWidget Evolve PhoneNumberInternationalWidget to PhoneNumberWithFallbackWidget Sep 1, 2022
@francoisfreitag
Copy link
Collaborator Author

I would like to include this change in the upcoming 7.0.0, so that we keep the breaking changes together.

@francoisfreitag francoisfreitag force-pushed the default-fmt branch 3 times, most recently from 0880358 to f21c853 Compare September 4, 2022 19:10
@francoisfreitag francoisfreitag changed the title Evolve PhoneNumberInternationalWidget to PhoneNumberWithFallbackWidget Evolve PhoneNumberInternationalWidget to RegionalPhoneNumberWidget Sep 4, 2022
Instead of hardcoding the INTERNATIONAL format, follow the
PHONENUMBER_DEFAULT_FORMAT preference (defaulting to E164).

The PhoneNumberInternationalWidget is now deprecated and will be removed
in the next major version. Use PhoneNumberWithFallbackWidget with
setting PHONENUMBER_DEFAULT_FORMAT="INTERNATIONAL" instead.
@francoisfreitag francoisfreitag merged commit ecf086c into stefanfoulis:main Sep 7, 2022
@francoisfreitag francoisfreitag deleted the default-fmt branch September 7, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants