Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement region argument for serializerfields #519

Merged

Conversation

francoisfreitag
Copy link
Collaborator

@francoisfreitag francoisfreitag commented Aug 26, 2022

The region argument was implemented for the database field and form
field, but not the Django REST framework serializers.
Align the serializer with the other fields.

Add a bunch of tests for that field.

Fixes #427

@francoisfreitag francoisfreitag force-pushed the serializer-region branch 6 times, most recently from 6ac499e to 0086c86 Compare August 28, 2022 13:53
The region argument was implemented for the database field and form
field, but not the Django REST framework serializers.
Align the serializer with the other fields.

Add a bunch of tests for that field.
@francoisfreitag francoisfreitag merged commit 1f012e4 into stefanfoulis:main Aug 28, 2022
@francoisfreitag francoisfreitag deleted the serializer-region branch August 28, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow different region validation in DRF SerializerField from PHONENUMBER_DEFAULT_REGION
1 participant