-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any objection if I add Dockerfile here ? #869
Comments
Regarding your title: a Dockerfile for swtpm should probably install the swtpm from the git repo rather than a specific old version from a distro |
sure, I can do that, absolutely |
My preference would be that I don't have to deal much with updating the versions installed in the container and the version of the underlying distro and that others don't feel the need to add Dockerfiles for their favorite distro because then it becomes endless. |
Yep, understood, minimal support is a requirement. |
Hi @glimchb, if I may, is there any chance that your contribution will lead to a container where we can use swtpm seamlessly? |
FYI: I am testing swtpm across distros in this project here: https://github.com/stefanberger/swtpm-distro-compile/ Maybe you can derive a Dockerfile from either one of these. Alpine seems to be a distro that produces a small image iirc. |
@stefanberger I also saw this repo... it that maintained ? |
@lmussier let me know if that works, I will try to replicate same behavior here, just using latest code instead of DEB pre-built package... |
Fixed stefanberger#869 Used multi-stage build here to reduce final image size. Builder should have packages for dev and compile. Final image should only have dependencies for runtime. Building is simple using `docker build .` command. Next patch will add: - linter - build - tpm2 tools testing Signed-off-by: Boris Glimcher <[email protected]>
Fixes stefanberger#869 Using popular Hadolint linter for dockers. Using standard GitHub action for building. Build will also publish to GHCR after PR is merged, not before. Signed-off-by: Boris Glimcher <[email protected]>
Fixed stefanberger#869 Used multi-stage build here to reduce final image size. Builder should have packages for dev and compile. Final image should only have dependencies for runtime. Building is simple using `docker build .` command. Or `docker build --build-arg="LIBTPMS_BRANCH=v0.9.6" .` if you want another branch/tag of libtpms. Next patch will add: - linter - build - tpm2 tools testing Signed-off-by: Boris Glimcher <[email protected]>
Fixes stefanberger#869 Using popular Hadolint linter for dockers. Using standard GitHub action for building. Build will also publish to GHCR after PR is merged, not before. Signed-off-by: Boris Glimcher <[email protected]>
Fixed stefanberger#869 Used multi-stage build here to reduce final image size. Builder should have packages for dev and compile. Final image should only have dependencies for runtime. Building is simple using `docker build .` command. Or `docker build --build-arg="LIBTPMS_BRANCH=v0.9.6" .` if you want another branch/tag of libtpms. Next patch will add: - linter - build - tpm2 tools testing Signed-off-by: Boris Glimcher <[email protected]>
Fixes stefanberger#869 Using popular Hadolint linter for dockers. Using standard GitHub action for building. Build will also publish to GHCR after PR is merged, not before. Signed-off-by: Boris Glimcher <[email protected]>
sorry it took me few days - I was ooo PR submitted for review based on alpine docker |
I publish docker image automatically to if you want to publish docker also to https://hub.docker.com/u/stefanberger everything is ready, just to have 2 secrets defined in this repo settings: |
Fixed stefanberger#869 Used multi-stage build here to reduce final image size. Builder should have packages for dev and compile. Final image should only have dependencies for runtime. Building is simple using `docker build .` command. Or `docker build --build-arg="LIBTPMS_BRANCH=v0.9.6" .` if you want another branch/tag of libtpms. Next patch will add: - linter - build - tpm2 tools testing Signed-off-by: Boris Glimcher <[email protected]>
Fixes stefanberger#869 Using popular Hadolint linter for dockers. Using standard GitHub action for building. Build will also publish to GHCR after PR is merged, not before. Signed-off-by: Boris Glimcher <[email protected]>
Fixes #869 Using popular Hadolint linter for dockers. Using standard GitHub action for building. Build will also publish to GHCR after PR is merged, not before. Signed-off-by: Boris Glimcher <[email protected]>
opened new #876 to publish to https://hub.docker.com/u/stefanberger |
wiki page https://github.com/stefanberger/swtpm/wiki/Dockerfiles is not enough...
something like this is super easy and helpful:
lint passed:
build:
run:
The text was updated successfully, but these errors were encountered: