Issue GetDKAN#3839: Disentangle harvest register and revert - review …

…feedback
stefan-korn · Sep 26, 2023 · cb1af2a · cb1af2a
1 parent f43da06
commit cb1af2a
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/modules/harvest/src/Commands/HarvestCommands.php b/modules/harvest/src/Commands/HarvestCommands.php
@@ -127,15 +127,12 @@ protected function buildPlanFromOpts($opts) {
    */
   public function deregister($id) {
     $message = 'Could not deregister the ' . $id . ' harvest.';
-    $this->logger->warning('If you deregister a harvest with published datasets, you will not be able to bulk revert the datasets connected to this harvest.');
+    $this->logger->warning(
+      'If you deregister a harvest with published datasets, you will
+       not be able to bulk revert the datasets connected to this harvest.');
     if ($this->io()->confirm("Deregister harvest {$id}")) {
-      try {
-        if ($this->harvestService->deregisterHarvest($id)) {
-          $message = 'Successfully deregistered the ' . $id . ' harvest.';
-        }
-      }
-      catch (\Exception $e) {
-        $message = $e->getMessage();
+      if ($this->harvestService->deregisterHarvest($id)) {
+        $message = 'Successfully deregistered the ' . $id . ' harvest.';
       }
     }
     else {