Bridge and Device discovery #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @coeing, I need to resolve the TODOs regarding the httpClient, but feel free to take a look and discover your Smart Home. |
@GerdZanker Yay, this is great and it makes the usage of our binding so much more comfortable :) I will check it out soon. |
coeing
reviewed
Feb 26, 2021
...hshc/src/main/java/org/openhab/binding/boschshc/internal/devices/bridge/BoschHttpClient.java
Show resolved
Hide resolved
| @Nullable | ||
| BoschHttpClient httpClient = this.httpClient; | ||
| if (httpClient == null) { | ||
| return false; | ||
| return null; |
There was a problem hiding this comment.
In my opinion we should start to throw something like a NotInitializedException in cases like this. What do you think?
There was a problem hiding this comment.
- throw exception instead return null - will also avoid @nullable
| @Nullable | ||
| ArrayList<Device> devices = null; | ||
| devices = shcBridgeHandler.getDevices(); | ||
| for (Device device : devices) { |
There was a problem hiding this comment.
Don't forget the null check :)
If a GET returns the public information, then the returned shcIpAddress is reported as discovered bridge. Signed-off-by: Gerd Zanker <[email protected]> fixes and improvements for bridge discovery Signed-off-by: Gerd Zanker <[email protected]>
Signed-off-by: Gerd Zanker <[email protected]>
GerdZanker
force-pushed
the
feature/Discovery
branch
from
23f3a35 to
aa4fefd
Compare
|
This pull request is replaced with a new openhab pull request now merged directly to main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bridge and Device discovery for Bosch Smart Home
Bridge IP address is discovered via mDNS and query of public information
Device discovery requires a paired bride and must be started manually via "Scan" button.
Currently not all supported devices are discovered, but ShutterControl and TwinGuard shall work.
A lot of debugs and traces are in to simplify problem analysis.
Unit tests are pending, but needed to keep functionality stable for future.