forked from openhab/openhab-addons
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle change of Home Controller system password correctly #55
Comments
coeing
added a commit
that referenced
this issue
Oct 18, 2020
Signed-off-by: Christian Oeing <[email protected]>
coeing
added a commit
that referenced
this issue
Oct 22, 2020
Signed-off-by: Christian Oeing <[email protected]>
coeing
added a commit
that referenced
this issue
Nov 18, 2020
Signed-off-by: Christian Oeing <[email protected]>
GerdZanker
pushed a commit
that referenced
this issue
Jan 7, 2021
Signed-off-by: Christian Oeing <[email protected]>
GerdZanker
pushed a commit
that referenced
this issue
Jan 7, 2021
Signed-off-by: Christian Oeing <[email protected]> Signed-off-by: Gerd Zanker <[email protected]>
GerdZanker
added a commit
that referenced
this issue
Jan 16, 2021
The changeable SHC system password for the keystore is replaced by a static string in the code. The keyStore name is now based on SHC ipAddress to support multiple SmartHomeControllers. Signed-off-by: Gerd Zanker <[email protected]>
GerdZanker
added a commit
that referenced
this issue
Jan 16, 2021
The changeable SHC system password for the keystore is replaced by a static string in the code. The keyStore name is now based on SHC ipAddress to support multiple SmartHomeControllers. Signed-off-by: Gerd Zanker <[email protected]>
@GerdZanker I think this is fixed with your last pull request, isn't it? |
Yes, its avoided with PR #70, because the keystore password is now a static password defined in code. Drawback: A new keystore will be created using your SHC IP address and a new pairing is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A change of SHC "system password" is an issue and happening also during initial setup of the binding e.g. if the wrong password was used instead of the App password.
See also comments in openhabCommunity.
The current solution is to delete the /etc/oss_openhab_binding_*.jks file in your openhab installation because the binding will recreate the jks file.
TODO from
BoschSslUtil.java
:In the meantime the initial pull request is discussed and from comments we can use "reference" code from openhab core how certificate handling is done there.
See CertificateGenerator.java and the generateCertificate() function how the password, and self singed cert creation is done.
With this reference we should get rid of password problems, by using a single fixed password ins the code and avoid at least the
bcprov-jdk15on
bundle dependency, which increases the jar size a lot.The text was updated successfully, but these errors were encountered: