Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect incorrect device ID instead of showing the thing as "Online" #34

Closed
coeing opened this issue Aug 11, 2020 · 1 comment · Fixed by #90
Closed

Detect incorrect device ID instead of showing the thing as "Online" #34

coeing opened this issue Aug 11, 2020 · 1 comment · Fixed by #90
Assignees
@coeing
Labels
enhancement New feature or request
Milestone
1.2

Comments

@coeing
Copy link
Collaborator

coeing commented Aug 11, 2020

Right now any configured thing that has a bridge is shown as "Online", even if the specified device id is invalid (any string possible). We should do a test request to the controller on initialization to check if a device with this ID exists. It might be enough to do this only when the device ID was first set or changed, but as a first step I would do it on each initialization. This can be implemented in the base class BoschSHCBridgeHandler
This was referenced Aug 11, 2020
Merged
Closed
@coeing coeing added the enhancement New feature or request label Aug 11, 2020
@coeing coeing added this to the 2.0 milestone Aug 11, 2020
@coeing coeing self-assigned this Feb 16, 2021
coeing added a commit that referenced this issue Feb 16, 2021
@coeing
#34 Get device info on thing initialization to check if device exists
903ca3a
@coeing coeing mentioned this issue Feb 16, 2021
Merged
coeing added a commit that referenced this issue Feb 16, 2021
@coeing
#34 Get device info on thing initialization to check if device exists
891aedb 
Signed-off-by: Christian Oeing <[email protected]>
@coeing coeing linked a pull request Feb 18, 2021 that will close this issue
Check device ID when initializing a thing handler #90
Merged
coeing added a commit that referenced this issue Feb 22, 2021
@coeing
#34 Get device info on thing initialization to check if device exists
2dc8d78 
Signed-off-by: Christian Oeing <[email protected]>
coeing added a commit that referenced this issue Feb 22, 2021
@coeing
#34 Use generic sendRequest method of http client to have consistent …
3936ed1 
…error handling

Signed-off-by: Christian Oeing <[email protected]>
coeing added a commit that referenced this issue Feb 22, 2021
@coeing
#34 Fix formatting error when logging device info
c9a7a10 
Signed-off-by: Christian Oeing <[email protected]>
coeing added a commit that referenced this issue Feb 23, 2021
@coeing
#34 Get device info on thing initialization to check if device exists
3835e9e 
Signed-off-by: Christian Oeing <[email protected]>
coeing added a commit that referenced this issue Feb 23, 2021
@coeing
#34 Use generic sendRequest method of http client to have consistent …
1c8fd70 
…error handling

Signed-off-by: Christian Oeing <[email protected]>
coeing added a commit that referenced this issue Feb 23, 2021
@coeing
#34 Fix formatting error when logging device info
e58868e 
Signed-off-by: Christian Oeing <[email protected]>
@coeing
Copy link
Collaborator Author

coeing commented Feb 23, 2021

Fixed by #90

@coeing coeing closed this as completed Feb 23, 2021
@coeing coeing mentioned this issue Jul 29, 2021
Closed
@coeing coeing modified the milestones: 2.0, 1.2 Jul 29, 2021
@coeing coeing mentioned this issue Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coeing coeing

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Check device ID when initializing a thing handler stefan-kaestle/openhab2-addons
1 participant
@coeing