Version 1.0 Discussion

[coeing]

As we talked about in several issues, we'd like to publish a first version to openHAB soon. We can use this issue to discuss what needs to be done and how the publishing progresses.

@stefan-kaestle As you are the initiator of the plugin, you should approach the devs from openHAB to ask for a roadmap for publishing a plugin. It might just be a pull request of a branch of our fork to their main repository, but maybe there is more to it.

[stefan-kaestle]

Will do.

[stefan-kaestle]

https://community.openhab.org/t/towards-merging-the-new-bosch-shc-binding/101952

Please add stuff there in case I forgot something 🙉

[coeing]

@GerdZanker @stefan-kaestle As far as I can see it we should be ready for a first pull request, what do you think? :) I would also create a new Pre-release 0.2 to let @tuxianerDE check issue #24 Other than that we have only enhancement issues left which we should work on after the first pull request went through. We might get some valuable feedback from the first official release, so I wouldn't wait any longer :)

[tuxianerDE]

Will update tomorrow to the other build and give feedback on the issue. Happy to see proceeding to a first release

[GerdZanker]

I can only think that issue #7 with a better folder structure could make a review simpler, but I can't judge about the needed effort and if IDE "move" Refactoring is sufficient.

[coeing]

@GerdZanker Yes, that's true, moving the classes to their (final) destination might make sense before the first release. I'll see if I find some time for it tomorrow, it shouldn't take too long.

[tuxianerDE]

Just for all on that thread. Issue #24 is resolved, as well as the shutter control. Looking forward to release 1.0

[coeing]

@GerdZanker @stefan-kaestle I will write an update to the thread in the openHAB forum to tell them we are ready to merge a first version :)

[coeing]

@GerdZanker @stefan-kaestle Unfortunately no anwer yet in the openHAB forum: https://community.openhab.org/t/towards-merging-the-new-bosch-shc-binding/101952/6

If there is no answer until next weekend, I would just send a pull request and we discuss any remaining issues in the pull request directly.

[stefan-kaestle]

Thanks for all your efforts guys! And sorry I have been unresponsive.
Is there anything that I should do for the release? Should I sign off my commits?

I'm generally a bit discouraged by the OpenHab maintainers. This binding was (and is) a lot of work and you'd think they are a bit more excited about us wanting to merge it 😉

[GerdZanker]

I also prefer a pull request over waiting for some forum feedback. With pull request the maintainer can't ignore the contribution. Because the code appears with PR on the openhab repo and is more visible I guess we can reach more excited users.

[coeing]

Thanks for all your efforts guys! And sorry I have been unresponsive.
Is there anything that I should do for the release? Should I sign off my commits?

I'm generally a bit discouraged by the OpenHab maintainers. This binding was (and is) a lot of work and you'd think they are a bit more excited about us wanting to merge it 😉

No problem @stefan-kaestle ! I can completely understand that there are times where there is no time to work on an open source project. It's good that we are 3 developers already, so our binding always goes forward a bit :)

I also prefer a pull request over waiting for some forum feedback. With pull request the maintainer can't ignore the contribution. Because the code appears with PR on the openhab repo and is more visible I guess we can reach more excited users.

From my side we can already create a pull request and don't have to wait any longer for an answer in the forum as well. It's probably better anyway to have a discussion about coding issues inside a pull request instead of a forum thread. @stefan-kaestle Do you want to create the pull request?

[VL2019]

Hi team,

thanks for your effort to develop a binding for Bosch Smart Home!

I have an OH2.5 environment and would like to include my new Bosch Smart Home System (Smoke detector, Shutter and motion detector). I am happy to help with some test in my environment.

Should I wait for the official first Version of your binding or do you think this will take some time and i should start with the pre-release beta 0.1

Thanks :-)

[GerdZanker]

Hello @VL2019,
warm welcome and feel free to start immediately testing our v1.0-beta.1 Version.

[coeing]

@GerdZanker @stefan-kaestle It's on! openhab#8371 :) If any work should come from this pull request, we should open new issues here to work on them. I already created one for the unsigned commits (#43)

[coeing]

There do not seem to be any more unresolved issues in the pull request, @GerdZanker is working on the remaining ones if I see it correctly :)

@GerdZanker Let me know if you resolved the issues you are working on. Afterwards we can start a new round of reviews. I guess there will be some more issues left, but not that many and that big as in the first round.

We are getting closer to the first release!

[VL2019]

Hi,
until the first release is not published, I try to work with the beta version.

I add the file in the add-on folder, restart OH, add the thing & item files and hold the button on the Gateway until the LED flash. But when I link an item to my motion sensor, I got this message in the log and on the UI:

2020-09-21 11:09:15.788 [hingStatusInfoChangedEvent] - 'boschshc:motion-detector:xxxxx' changed from ONLINE to OFFLINE (COMMUNICATION_ERROR): Bridge or config is NUL

Do you have any idea, what I did wrong?
And do you plan to add the "normal" smoke detector as well or can I use the twinGuard code?

[tuxianerDE]

hey VL2019,

can you raise a seperate issue for this observation just to keep things clean (and also track if this becomes an actual bug).

I can confirm that I have integrated my twinguard suessfully.

can you share in the new created issue your binding config for the controller and do other items work?

[VL2019]

Thanks, I think it was an issue with the controller connection. Now I add my password for the Bosch controller in the .thing file. I think it is Not the best way but it works for the moment 👍

I also have an smoke detector. Where I can create a support request for the next version? It would be nice to use the Audi signal for my alarm system in openHAB.

Thanks

Edit: maybe it would be better to trigger the alarm from Bosch in openHAB. I think the usecase to control each smoke detector is not so huge. But to start/trigger the alarm would be great

[coeing]

@tuxianerDE Thanks for the quick answer! :)

@VL2019 As @tuxianerDE described, you should open new issues for bug reports and feature requests as well. This way the discussions stay focused on one topic at a time.

I will upload a new Beta version soon because we did a lot of code refactoring during the first review of the openHAB maintainers. Hope you all have time to test a bit if everything still works :)

[coeing]

@GerdZanker Added a new branch bosch-shc-3.0 which is rebased on openhab/main. The next step would be to get it running locally with an openHAB setup. Let me know when it works for you, I will see when I have time to try it :)

[coeing]

@GerdZanker Small update, I was too curious to wait trying it out ;) I had to fix some formatting and cherry picked your commit. So the branch is up-to-date :) Will do some testing with my devices and upload a new beta release, so others can test as well.

[tuxianerDE]

@coeing just FYI I am still using the initial release version that I have configured to control all items I have and that can be configured so far. Can't wait to test the improved version :)

[coeing]

@GerdZanker Unfortunately I can't get the pairing to work and I am not sure if it's me, openHAB 3 or something else :/ Let me know when you had time to look at it, hopefully you can figure it out quickly (if it is a problem for you as well).

[coeing]

Quick update: @GerdZanker fixed the pairing bug I introduced (shame on me!). As soon as the fix is merged I will create a new beta release. It will be for openHAB 3 though because unfortunately our binding won't make it into openHAB 2.5 anymore :/

[coeing]

Our binding is merged! :D openhab#8629 It will be released with openHAB 3.1 and should already be included in the latest snapshot: https://www.openhab.org/download/

[stefan-kaestle]

Wow! Awesome job guys! Seeing how much extra work this was in the end, there is no way this would have happened without all your contributions and help!
Sorry I couldn't help more with the merging. I was and still am pretty busy (👶 among other things).

Thanks again and much appreciated!

[coeing]

Wow! Awesome job guys! Seeing how much extra work this was in the end, there is no way this would have happened without all your contributions and help!
Sorry I couldn't help more with the merging. I was and still am pretty busy (👶 among other things).

Thanks again and much appreciated!

Thanks, @stefan-kaestle and thanks for starting this binding :) And congrats on the birth! 👍 Btw: My son was born on November 23rd 2020, so they shouldn't be too far apart ;)

[tuxianerDE]

Thanks all for making this work and congrats making it now to the official releaes train for openhab 3.1

@stefan-kaestle congrats on the birth of your kid!!! All the best

[stefan-kaestle]

Btw: My son was born on November 23rd 2020, so they shouldn't be too far apart ;)

Awesome, congratulations! Now I'm triple impressed with your contribution :-)
Mine was born on December 10th, so yes, very close!