Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM + CJS builds #72

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GerkinDev
Copy link

@GerkinDev GerkinDev commented Sep 7, 2021

This PR builds the package in both ESM & CJS formats, with backward compatibility. Relates to #64

Additionally:

Note: This PR can be installed directly with npm i github:GerkinDev/lodash-decorators#build/esm-cjs-build

🍻

@GerkinDev
Copy link
Author

Please tell me if this change interests you. If it does, please wait before merging. Some build deps changes in configs requires updates in package versions causing chained deprecations. So I must update most of dev deps.

This pr is not mergeable as is and won't work due to outdated typescript incompatible with required config

@GerkinDev
Copy link
Author

Some parts of this PR have been moved in #74 , which should be merged before it.

@naranjamecanica
Copy link

Very nice, is this something that can be merged together with #74 ?

@GerkinDev
Copy link
Author

Hi,

Yeah, if you're OK with this PR & #74 , start by merging #74 then this one.

Since this PR has been stall for a couple of month, I don't know anymore if it requires extra tweakings, but I don't think so.

@GerkinDev GerkinDev mentioned this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants