add go to previous error #678
Conversation
despairblue
force-pushed
the
feature/previous-error
branch
from
f030c7f to
1e3862d
Compare
despairblue
force-pushed
the
feature/previous-error
branch
from
1e3862d to
8a5947b
Compare
| message = next.value | ||
| return unless message.filePath | ||
| return unless message.range | ||
| if @index? |
There was a problem hiding this comment.
Seems like we should really be indexing errors by some sort of hash of position and file name. Otherwise changes to the full set of messages would not have a stable order. This is of course assuming our linter messages have a stable order.
On that note we should really have a stable order, because it doesn't look like multiple linters actually have a stable order in our error processing.
There was a problem hiding this comment.
True. I tried it with one linter, that was stable, but if there are tow and they report asynchronously it's going to be a problem as soon as one changes something.
The behavior before this PR was to always jump to the first reported error after an edit.
|
🚢 Seems fine other than the overarching issue of usability. We should really add a story to address the order of errors across linter. |
|
I extracted the modulo into a method and added an explanation. |
|
Merging based on review from @park9140 |
No description provided.