Change linterViews to be an ES6 Set rather than an Array. #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to remove a dependency on `lodash` in `init.coffee`. Curiously, this was my first justified use of the [Embedded JavaScript](http://coffeescript.org/#embedded) feature in CoffeeScript because I needed to use the ES6 iteration idiom for `Set`, for which there is no equivalent in CoffeeScript.
|
I've never had to use that embedded javascript feature either. Interesting! |
dmnd
added a commit
that referenced
this pull request
Feb 18, 2015
Change linterViews to be an ES6 Set rather than an Array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to remove a dependency on
lodashininit.coffee.Curiously, this was my first justified use of the
Embedded JavaScript feature in
CoffeeScript because I needed to use the ES6 iteration idiom for
Set,for which there is no equivalent in CoffeeScript.
This also updates
deactivate()to null out references so they can be garbage collected.This is good practice if a package toggles between activated and deactivated.