Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public method beforeSpawnProcess: (command, args, options) to Linter #290

Merged
merged 1 commit into from
Apr 21, 2015

Conversation

liigo
Copy link

@liigo liigo commented Dec 15, 2014

Gives subclasses a chance to read or change the command, args and options, before creating new BufferedProcess while lintFile.

This is a backward compatible improvement.

Closes #289

PS: I'a a newbie of CoffeeScript .

…ss Linter.

Gives subclasses a chance to read or change the command, args and options, before creating new BufferedProcess while lintFile.

This is a backward compatible improvment.

Closes steelbrain#289
@dmnd
Copy link

dmnd commented Dec 15, 2014

cool, can you link to the rust linter code that uses this?

@liigo
Copy link
Author

liigo commented Dec 16, 2014

@dmnd This is the forked repo I'm working on:

https://github.com/liigo/linter-rust/blob/master/lib/linter-rust.coffee#L62L72

I try to find file Cargo.toml (in @initCmd) to decide which command to use: either cargo or rustc. It works now to invoke cargo. Obviously there need more work to show errors and warnings that cargo reports.

@liigo
Copy link
Author

liigo commented Dec 19, 2014

@dmnd I also submitted a PR to Rust Linter: AtomLinter/linter-rust#5, which depends on this improvement.

@jhasse
Copy link

jhasse commented Apr 14, 2015

Any news on getting this merged?

@KingOfThePirates
Copy link

I would like news too :)

@iam4x
Copy link
Contributor

iam4x commented Apr 21, 2015

Let's merge it, though @dmnd was on it since he answered first :)

iam4x pushed a commit that referenced this pull request Apr 21, 2015
Add public method beforeSpawnProcess: (command, args, options) to Linter
@iam4x iam4x merged commit 4c9d7c9 into steelbrain:master Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: modify command and args before create new BufferedProcess
5 participants