Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog before preparing Atom release #222

Closed
ilanbiala opened this issue Sep 25, 2014 · 5 comments
Closed

Update changelog before preparing Atom release #222

ilanbiala opened this issue Sep 25, 2014 · 5 comments

Comments

@ilanbiala
Copy link

It's really frustrating that the version I'm updating to isn't in the changelog because it's updated after someone prepare's the release using APM. Can you guys commit the changelog first from now on?

@dmnd
Copy link

dmnd commented Sep 25, 2014

Hmm. The last 3 versions all have changelog updates immediately before a release (top is more recent in these pics):

image

image

image

What is showing up when you update? Maybe I'm doing something wrong.

@ilanbiala
Copy link
Author

Change log in atom is always 1 version behind.

@dmnd
Copy link

dmnd commented Sep 27, 2014

I don't understand how the changelog is one version behind. I'll have to look into this. Do you have any pointers to docs?

@ilanbiala
Copy link
Author

What I do is before I apm publish, I just commit the changelog with the new vesion and all the changes, but without the SHA hash, so from:

# [0.7.7](357ee8761a801f505305fadd475a13255eb18b73)

* Fixed regression where closing a tab would throw an error

to

# [0.7.8]()

* Added `end_with_newline` setting.

# [0.7.7](357ee8761a801f505305fadd475a13255eb18b73)

* Fixed regression where closing a tab would throw an error

Then I apm publish, and on the next commit, I add the SHA hash inside the parens.

@dmnd
Copy link

dmnd commented Oct 27, 2014

That's pretty much what I do. I update the changelog, then apm publish to release the new version. You can see this in the screenshot above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants