Skip to content

Commit

Permalink
DEBUG: figure out CI issues
Browse files Browse the repository at this point in the history
Change-Id: I4ff15e614196e60308d58a5e0812592f1fd0e40f
  • Loading branch information
steadmon committed Mar 5, 2024
1 parent 3ea090e commit f59a3c2
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 4 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -265,42 +265,54 @@ jobs:
vector:
- jobname: linux-sha256
cc: clang
cxx: clang++
pool: ubuntu-latest
- jobname: linux-reftable
cc: clang
cxx: clang++
pool: ubuntu-latest
- jobname: linux-gcc
cc: gcc
cxx: g++
cc_package: gcc-8
pool: ubuntu-20.04
- jobname: linux-TEST-vars
cc: gcc
cxx: g++
cc_package: gcc-8
pool: ubuntu-20.04
- jobname: osx-clang
cc: clang
cxx: clang++
pool: macos-13
- jobname: osx-reftable
cc: clang
cxx: clang++
pool: macos-13
- jobname: osx-gcc
cc: gcc
cxx: g++
cc_package: gcc-13
pool: macos-13
- jobname: linux-gcc-default
cc: gcc
cxx: g++
pool: ubuntu-latest
- jobname: linux-leaks
cc: gcc
cxx: g++
pool: ubuntu-latest
- jobname: linux-reftable-leaks
cc: gcc
cxx: g++
pool: ubuntu-latest
- jobname: linux-asan-ubsan
cc: clang
cxx: clang++
pool: ubuntu-latest
env:
CC: ${{matrix.vector.cc}}
CXX: ${{matrix.vector.cxx}}
CC_PACKAGE: ${{matrix.vector.cc_package}}
jobname: ${{matrix.vector.jobname}}
runs_on_pool: ${{matrix.vector.pool}}
Expand Down
19 changes: 15 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,9 @@ include shared.mak
# to the "<name>" of the corresponding `compat/fsmonitor/fsm-settings-<name>.c`
# that implements the `fsm_os_settings__*()` routines.
#
# Define LINK_FUZZ_PROGRAMS if you want `make all` to also build the fuzz test
# programs in oss-fuzz/.
#
# === Optional library: libintl ===
#
# Define NO_GETTEXT if you don't want Git output to be translated.
Expand Down Expand Up @@ -764,9 +767,6 @@ FUZZ_OBJS += oss-fuzz/fuzz-pack-idx.o
fuzz-objs: $(FUZZ_OBJS)

FUZZ_PROGRAMS += $(patsubst %.o,%,$(filter-out %dummy-cmd-main.o,$(FUZZ_OBJS)))
# Always build fuzz programs; even without the necessary fuzzing support, this
# prevents bit-rot.
all:: $(FUZZ_PROGRAMS)

# Empty...
EXTRA_PROGRAMS =
Expand Down Expand Up @@ -2368,6 +2368,14 @@ ifndef NO_TCLTK
endif
$(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1) SHELL_PATH='$(SHELL_PATH_SQ)' PERL_PATH='$(PERL_PATH_SQ)'

# Always build fuzz programs if possible, or at least compile the object files;
# even without the necessary fuzzing support, this prevents bit-rot.
ifdef LINK_FUZZ_PROGRAMS
all:: $(FUZZ_PROGRAMS)
else
all:: $(FUZZ_OBJS)
endif

please_set_SHELL_PATH_to_a_more_modern_shell:
@$$(:)

Expand Down Expand Up @@ -3865,7 +3873,10 @@ FUZZ_CXXFLAGS ?= $(ALL_CFLAGS)
$(FUZZ_PROGRAMS): %: %.o oss-fuzz/dummy-cmd-main.o $(GITLIBS) GIT-LDFLAGS
$(QUIET_LINK)$(CXX) $(FUZZ_CXXFLAGS) -o $@ $(ALL_LDFLAGS) \
-Wl,--allow-multiple-definition \
$(filter %.o,$^) $(filter %.a,$^) $(LIBS) $(LIB_FUZZING_ENGINE)
$(filter %.o,$^) $(filter %.a,$^) $(LIBS) $(LIB_FUZZING_ENGINE) \
$(info COMPILER_FEATURES is [${COMPILER_FEATURES}])\
$(info CC is [${CC}])\
$(info CXX is [${CXX}])\

fuzz-all: $(FUZZ_PROGRAMS)

Expand Down
1 change: 1 addition & 0 deletions config.mak.uname
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ ifeq ($(uname_S),Linux)
ifneq ($(findstring .el7.,$(uname_R)),)
BASIC_CFLAGS += -std=c99
endif
LINK_FUZZ_PROGRAMS = YesPlease
endif
ifeq ($(uname_S),GNU/kFreeBSD)
HAVE_ALLOCA_H = YesPlease
Expand Down

0 comments on commit f59a3c2

Please sign in to comment.