Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for accessor arrays and refactor stats/base/cumaxabs #5289

Merged
merged 6 commits into from
Feb 19, 2025
Merged

feat: add support for accessor arrays and refactor stats/base/cumaxabs #5289

merged 6 commits into from
Feb 19, 2025

Conversation

vivekmaurya001
Copy link
Contributor

Resolves #{{TODO: add issue number}}.

This pull request:

  • add accessor arrays support and refactor stats/base/cumaxabs

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@vivekmaurya001
add support for accessor arrays
a0ffbb9 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 18, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 18, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/cumaxabs $\color{green}361/361$
$\color{green}+100.00\%$ 		$\color{green}30/30$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}361/361$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001 vivekmaurya001 marked this pull request as draft February 18, 2025 13:43
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 18, 2025
@vivekmaurya001
add support for accessor arrays
1f038a4
@vivekmaurya001
feat: add support for accessor arrays and refactor stats/base/cumaxabs
e3daffc 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review February 18, 2025 13:54
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 18, 2025
@vivekmaurya001
Copy link
Contributor Author

@kgryte , it is ready for review

kgryte
kgryte approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Feb 19, 2025
@kgryte kgryte merged commit c17d1c9 into stdlib-js:develop Feb 19, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekmaurya001 @stdlib-bot @kgryte