New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add `ndarray/base/mskfilter` #2604

Draft

Jaysukh-409 wants to merge 39 commits into stdlib-js:develop from Jaysukh-409:ndarray/base/mskfilter

Member

Jaysukh-409 commented Jul 15, 2024

Description

What is the purpose of this pull request?

This pull request:

This PR will add ndarray/base/mskfilter.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Jaysukh-409 added 2 commits

July 15, 2024 16:02


          chore: create folder structure and add example

2836e0d


          feat: add kernels for 0d ndarray

67dfb52

kgryte added the Feature label

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/0d_accessors.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/0d.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/package.json Outdated Show resolved Hide resolved

Jaysukh-409 added 3 commits

July 30, 2024 16:43


          feat: add kernels for 1d ndarray

2f0ba4c


          refactor: update the implementation for 1d kernels

d5bcb07


          feat: add kernels for 2d ndarray

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/2d.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/2d.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/2d_accessors.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/2d_blocked.js Outdated Show resolved Hide resolved

Jaysukh-409 added 13 commits

August 2, 2024 12:20


          docs: update description of loop kernel

6f3992f


          docs: refactor JSDoc example for loop kernels

ecffc55


          refactor: update variable name for consistent naming convention

f531567


          feat: add kernels for 3d ndarray

8ff83b4


          feat: add kernels for nd ndarray


          feat: add kernels for 4d ndarray

9422eb5


          feat: add kernels for 5d ndarray

f318edb


          feat: add kernels for 6d ndarray

7235a97


          feat: add kernels for 7d ndarray

d7683e0


          feat: add kernels for 8d ndarray

ad939d1


          feat: add kernels for 9d ndarray

f149847


          feat: add kernels for 10d ndarray

121db5a


          docs: fix copy-paste error

f1e0a81

Member

kgryte commented Aug 7, 2024

@Jaysukh-409 You should go ahead and fix the lint failures so that CI can start passing.

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Outdated Show resolved Hide resolved

Jaysukh-409 and others added 4 commits

August 10, 2024 22:16


          test: add tests for 1d ndarray

da81461


          bench: add benchmark files

7515b00


          docs: added examples in readme

e2ac30c


          Apply suggestions from code review

f8926fb

Signed-off-by: Athan <[email protected]>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/examples/index.js Show resolved Hide resolved

Jaysukh-409 added 3 commits

August 17, 2024 03:55


          test: add tests for 2d ndaray

c193d8b


          Merge branch 'ndarray/base/mskfilter' of https://github.com/Jaysukh-4…

11cb348

…09/stdlib into ndarray/base/mskfilter


          docs: add repl and typescript declaration

3ed9b3d

Jaysukh-409 commented

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/repl.txt Outdated Show resolved Hide resolved

Jaysukh-409 and others added 2 commits

August 19, 2024 23:27


          test: add test for 3d to nd ndarray

59c2e81


          refactor: updated the implementation of mskfilter

099e730

Signed-off-by: Jaysukh Makvana <[email protected]>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md

+              var shape = [ 5, 2 ];
+              var x = {
+                  'dtype': 'float64',
+                  'data': filledarrayBy( N, 'float64', discreteUniform( -100, 100 ) ),

Member

kgryte Aug 17, 2024

Let's use random/array/discrete-uniform, random/array/bernoulli, and array/zeros for creating the array buffers.

lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/repl.txt Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/repl.txt Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/types/index.d.ts Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/types/index.d.ts Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/10d.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/10d.js Outdated Show resolved Hide resolved

Jaysukh-409 added 2 commits

August 21, 2024 18:27


          refactor: apply suggestions

eaec078


          Merge branch 'ndarray/base/mskfilter' of https://github.com/Jaysukh-4…

1e848e9

…09/stdlib into ndarray/base/mskfilter

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/mskfilter/lib/main.js Outdated Show resolved Hide resolved

Jaysukh-409 added 5 commits

September 16, 2024 16:41


          feat: update scripts

1d1acea


          feat: update scripts and templates

9c1003c


          feat: update templates and run script

4eeeb46


          feat: add macros for 1d and 2d ndarray

4e40c79


          fix: remove the unused variables

4d0ae78

Member

kgryte commented Jan 18, 2025

/stdlib merge

stdlib-bot added the bot: In Progress label


          Merge remote-tracking branch 'upstream/develop' into ndarray/base/msk…

b649357

…filter

stdlib-bot removed the bot: In Progress label

Member

kgryte commented Jan 18, 2025

/stdlib update-copyright-years

stdlib-bot added the bot: In Progress label


          chore: update copyright years

1548fa7

stdlib-bot removed the bot: In Progress label

Contributor

stdlib-bot commented Jan 18, 2025 •

edited

Loading

Coverage Report

Package	Statements	Branches	Functions	Lines
ndarray/base/mskfilter	$\color{red}10775/10782$ $\color{green}+99.94\%$	$\color{red}731/735$ $\color{green}+99.46\%$	$\color{green}43/43$ $\color{green}+100.00\%$	$\color{red}10775/10782$ $\color{green}+99.94\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature