Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add boolean dtype support to array/from-scalar #2470

Merged
merged 10 commits into from
Jun 29, 2024

Conversation

Jaysukh-409
Copy link
Member

Resolves: Subtask of #2304

Description

What is the purpose of this pull request?

This pull request:

  • This PR will add boolean datatype support in array/from-scalar.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Jaysukh-409 Jaysukh-409 added the Enhancement Issue or pull request for enhancing existing functionality. label Jun 28, 2024
@Jaysukh-409
Copy link
Member Author

Jaysukh-409 commented Jun 28, 2024

I think that in typescript declaration of array2scalar function, value's datatype shouldn't restricted to boolean only.
@kgryte Can you confirm the same ?
And this is the case then we need to add some more tests also.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409!

@kgryte kgryte merged commit 3a3116e into stdlib-js:develop Jun 29, 2024
8 checks passed
@kgryte kgryte deleted the from-scalar branch June 29, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issue or pull request for enhancing existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants