-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reverse
and toReversed
methods to array/bool
#2390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Jaysukh-409. This looks mostly good. Left a minor comment regarding implementation.
reverse
and toReversed
method to array/boolreverse
and toReversed
method to array/bool
…/Jaysukh-409/2390
reverse
and toReversed
method to array/bool
reverse
and toReversed
methods to array/bool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Jaysukh-409!
Tests are currently failing due to a circular dependency.
Looks like we need to revert the changes to use |
According to compat tables (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/reverse), typed arrays did not get a |
Resolves: Subtask of #2304
Description
This pull request:
reverse
andtoReversed
methods to prototype ofBooleanArray
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers